-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCHEMA] Add new MEG files and fix entity tables #898
Conversation
On the one hand, the filename templates look awesome:
On the other hand, the entity tables look terrible: "also meg" was the best I came up with 😞, and I just realized that the way I wrote the code, it can only handle two rows with the same datatype/suffixes, so... thoughts? |
Can we name these files |
@guiomar there's no mechanism to label the different groups of suffixes in the schema at the moment. We could add one, though I'm always hesitant to add new fields to the schema. EDIT: Yes, the new row corresponds to both calibration and crosstalk files. |
thanks! looks all good except the entity table, as you say :-)
Can we not make it |
That would be fine with me. The rest looks good. :-D |
@sappelhoff @Remi-Gau I can't think of a straightforward way to do that with the current schema, so I would need to add a new field, like "name", for labeling whole groups of suffixes in |
OK I am ok keeping like this for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am also OK with the current state. I think merging this and opening an issue on how to modify the schema that the meg (meg)
can become a meg (crosstalk & calibration)
would be a good way to go forward.
Thanks @tsalo for your work here
Hi! I think I missed when the calibration and crosstalk files were incorporated to the specs. I think they weren't on the first release. Why do they have the |
it happened here @guiomar :-) |
Thanks @sappelhoff! And it's not that you didn't tag me! |
Is everyone okay with me merging? |
Closes #810.
NOTE: This adds in support for objects/dictionaries within datatype rules for entities, which may impact code using the schema. Tagging @bids-standard/schema-users in case this might be a problem for any of you.
Changes proposed: